Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount: Wait for systemd temporary mount unit
......................................................................


mount: Wait for systemd temporary mount unit

Systemd is monitoring mountpoints created during runtime by creating a
temporary mount units. For example:

    # systemctl status /tmp/mount-1.DUNxySxI2R/wrk
    ‚óŹ tmp-mount\x2d1.DUNxySxI2R-wrk.mount - /tmp/mount-1.DUNxySxI2R/wrk
       Loaded: loaded (/proc/self/mountinfo)
       Active: active (mounted) since Sun 2016-04-24 22:37:55 IDT; 14ms ago
        Where: /tmp/mount-1.DUNxySxI2R/wrk
         What: /dev/loop2

Mounting and unmounting quickly as we do in the tests, or when creating
a floppy image may confuse systemd, and lead to various errors:

- mountpoint is not mounted when trying to access files or unmount
- mountpoint is busy when trying to unmount

These are probably systemd or mount bugs. Until these issues are
resolve, we need to find a workaround to avoid failures in the tests or
when creating a floppy images.

This patch add udevadm.settle() call after successful mount and umount
operations.

Change-Id: I9b0318eb534f781f127882983527e1a221820478
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56544
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <from...@redhat.com>
---
M lib/vdsm/storage/mount.py
M tests/mkimageTests.py
M tests/mountTests.py
3 files changed, 18 insertions(+), 16 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to