Francesco Romani has posted comments on this change.

Change subject: lib: response: helper to detect valid responses
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py
File lib/vdsm/common/response.py:

Line 85:         else:
Line 86:             return code != doneCode["code"]
Line 87: 
Line 88: 
Line 89: def is_valid(res):
> Lets add the docstring?
Done, eventually.
Line 90:     # catching AttributeError is even uglier
Line 91:     if not isinstance(res, dict):
Line 92:         return False
Line 93:     try:


-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to