Shmuel Leib Melamud has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
......................................................................


Patch Set 13:

(3 comments)

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64:     :param vol_path: path to the volume
Line 65:     """
Line 66:     cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68:     rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
> Also, do we have a virt-sparsify bug for this? We need a comment like this:
I've asked Richard. He is against setting this flag and asks instead, if it is 
not working, to turn libvirt debugging on and collect the logs.

So, what do you recommend - remove the setting as Richard asks or keep it 
because it works better?

On my system, I didn't succeed to run virt-sparsify without this flag.
Line 69: 
Line 70:     if rc != 0:


https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 27: 
Line 28: from . import base
Line 29: 
Line 30: 
Line 31: class Job(base.Job):
> Please keep empty line after the class declaration.
Done
Line 32:     def __init__(self, job_id, host_id, vol_info):
Line 33:         super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34:         self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
Line 35: 


Line 30: 
Line 31: class Job(base.Job):
Line 32:     def __init__(self, job_id, host_id, vol_info):
Line 33:         super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34:         self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
> True is not clear, better use writable=True - see copy_data.Job.__init__.
Done
Line 35: 
Line 36:     def _run(self):
Line 37:         with guarded.context(self._vol_info.locks):
Line 38:             with self._vol_info.prepare():


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to