Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
......................................................................


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64:     :param vol_path: path to the volume
Line 65:     """
Line 66:     cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68:     rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
> I've asked Richard. He is against setting this flag and asks instead, if it
Generally we should not use this flag, but in alignment scan case, after 
investing hours in debugging we did not have a choice.

If this work without the flag we should not use this flag, if it does not work, 
we don't have a choice.

To debug this, you should turn on libvirt debugging and open a bug with the 
results.
Line 69: 
Line 70:     if rc != 0:


https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 22: 
Line 23: from vdsm import virtsparsify
Line 24: from vdsm.storage import guarded
Line 25: 
Line 26: from .copy_data import CopyDataDivEndpoint
> I've asked Adam in e-mail about this:
The idea is to both move the code and rename the schema.

Lets see what Adam thinks about it.
Line 27: 
Line 28: from . import base
Line 29: 
Line 30: 


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to