Edward Haas has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG
Commit Message:

PS3, Line 18: fixies
> fixes
Done


https://gerrit.ovirt.org/#/c/64118/3/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

PS3, Line 204:     net_add_setup = 
ovs_switch.create_network_addition_setup(ovs_info)
             :     net_add_setup.add(nets2add)
             :     acq.acquire(net_add_setup.acquired_ifaces)
> do we need to keep setup class here? it would be easier to read if it was a
Initially I tried it in the same class (Setup), then decided to go with a 
separate class, dedicated for add (and another for remove).
Main reasoning was the multiple inner small methods, with multiple shared data. 
I prefer a class that can save the data for the methods to use it, over passing 
a large number of arguments between the methods. The later is just too messy 
for me.


-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to