Nir Soffer has posted comments on this change.

Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
......................................................................


Patch Set 4:

This change broke many tests - please make sure all tests pass before you 
upload the next version.

3:46:15 ======================================================================
23:46:15 ERROR: test_volume_chain_copy('block', 'raw', 'raw', (0, 1)) 
(storage_sdm_copy_data_test.TestCopyDataDIV)
23:46:15 ----------------------------------------------------------------------
23:46:15 Traceback (most recent call last):
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/testlib.py",
 line 85, in wrapper
23:46:15     return f(self, *args)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storage_sdm_copy_data_test.py",
 line 164, in test_volume_chain_copy
23:46:15     chain_length=nr_vols) as (src_chain,
23:46:15   File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
23:46:15     return self.gen.next()
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storage_sdm_copy_data_test.py",
 line 74, in get_vols
23:46:15     chain_length)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storagetestlib.py",
 line 356, in make_qemu_chain
23:46:15     format=qemuimg.FORMAT.QCOW2, backing=backing)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/vdsm/qemuimg.py",
 line 113, in create
23:46:15     cmd.extend(('-o', 'compat=' + _qcow2_compat(kwargs)))
23:46:15 TypeError: _qcow2_compat() takes exactly 0 arguments (1 given)
23:46:15 -------------------- >> begin captured logging << --------------------
23:46:15 2016-09-19 23:45:16,559 DEBUG   [storage.PersistentDict] (MainThread) 
Created a persistent dict with VGTagMetadataRW backend
23:46:15 2016-09-19 23:45:16,560 DEBUG   [storage.PersistentDict] (MainThread) 
read lines (VGTagMetadataRW)=[]
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Empty metadata
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Starting transaction
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Flushing changes
23:46:15 2016-09-19 23:45:16,562 DEBUG   [storage.PersistentDict] (MainThread) 
about to write lines (VGTagMetadataRW)=['CLASS=Data', 
'POOL_UUID=a65f91b4-d51c-49c7-92ec-d3767bd94e14', 
'SDUUID=3c02be87-d1da-4fa1-8fca-adfb7f4f63e5', 'VERSION=3', 
'_SHA_CKSUM=0c7bd0762a865207d4d00f5ae16b69a607125565']
23:46:15 2016-09-19 23:45:16,563 DEBUG   [storage.Metadata.VGTagMetadataRW] 
(MainThread) Updating metadata 
adding=MDT_POOL_UUID=a65f91b4-d51c-49c7-92ec-d3767bd94e14, MDT_VERSION=3, 
MDT_SDUUID=3c02be87-d1da-4fa1-8fca-adfb7f4f63e5, 
MDT__SHA_CKSUM=0c7bd0762a865207d4d00f5ae16b69a607125565, MDT_CLASS=Data 
removing=
23:46:15 2016-09-19 23:45:16,563 DEBUG   [storage.PersistentDict] (MainThread) 
Finished transaction
23:46:15 2016-09-19 23:45:16,568 WARNING [storage.StorageDomainManifest] 
(MainThread) Could not find mapping for lv 
3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/b8f76961-14df-4679-86c6-c21fe522cb8b
23:46:15 2016-09-19 23:45:16,569 DEBUG   [storage.StorageDomainManifest] 
(MainThread) Found freeSlot 4 in VG 3c02be87-d1da-4fa1-8fca-adfb7f4f63e5
23:46:15 2016-09-19 23:45:16,571 DEBUG   [storage.VolumeManifest] (MainThread) 
Creating symlink from 
/var/tmp/tmpBX_Rfb/dev/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/b8f76961-14df-4679-86c6-c21fe522cb8b
 to 
/var/tmp/tmpBX_Rfb/mnt/blockSD/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/images/d6ae6eb6-fb86-40e5-929b-8e554df0d1a2/b8f76961-14df-4679-86c6-c21fe522cb8b
23:46:15 2016-09-19 23:45:16,575 WARNING [storage.StorageDomainManifest] 
(MainThread) Could not find mapping for lv 
3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/8c4ecba5-0767-41a2-abb5-87afcc9b0949
23:46:15 2016-09-19 23:45:16,576 DEBUG   [storage.StorageDomainManifest] 
(MainThread) Found freeSlot 5 in VG 3c02be87-d1da-4fa1-8fca-adfb7f4f63e5
23:46:15 2016-09-19 23:45:16,583 DEBUG   [storage.VolumeManifest] (MainThread) 
Creating symlink from 
/var/tmp/tmpBX_Rfb/dev/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/8c4ecba5-0767-41a2-abb5-87afcc9b0949
 to 
/var/tmp/tmpBX_Rfb/mnt/blockSD/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/images/d6ae6eb6-fb86-40e5-929b-8e554df0d1a2/8c4ecba5-0767-41a2-abb5-87afcc9b0949
23:46:15 --------------------- >> end captured logging << ---------------------

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to