Martin Polednik has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 264: 
Line 265:         ('host_numa_scheduling', 'true',
Line 266:             'Enable implicit scheduling of VMs to properly match numa 
'
Line 267:             'topology. Explicit settings sent from engine disables 
the '
Line 268:             'scheduling.'),
> implicit scheduling ?
Way better.
Line 269:     ]),
Line 270: 
Line 271:     # Section: [rpc]
Line 272:     ('rpc', [


https://gerrit.ovirt.org/#/c/60640/15/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS15, Line 519: [dev_object.numa_node for dev_object in devices if
              :                     dev_object.is_hostdevice and 
dev_object.numa_node]
> Obfuscation contest?
How is this obfuscation? It literally reads "list of numa nodes for host 
devices with numa node available".


-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to