Ramesh N has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 329: try: Line 330: selinux.restorecon(mountPoint, recursive=True) Line 331: except OSError as e: Line 332: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename) Line 333: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, err=errMsg) > this works, no doubt about that, but why has not the parent directory (/rhg Only reason why we can't follow this approach is because /rhgs is not the mount point always. Default mount point is configurable in the ovirt engine and user can change the mount point to any location per brick. -- To view, visit https://gerrit.ovirt.org/62773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
