Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 329:         try:
Line 330:             selinux.restorecon(mountPoint, recursive=True)
Line 331:         except OSError as e:
Line 332:             errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, 
e.filename)
Line 333:             raise ge.GlusterHostFailedToRunRestorecon(mountPoint, 
err=errMsg)
> this works, no doubt about that, but why has not the parent directory (/rhg
Only reason why we can't follow this approach is because /rhgs is not the mount 
point always. Default mount point is configurable in the ovirt engine and user 
can change the mount point to any location per brick.


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to