Francesco Romani has posted comments on this change. Change subject: draft: migration plugin proposal - draft 102 ......................................................................
Patch Set 1: just looking at the names, I have a very bad feeling about the idea of adding plugins to an hook. Seems a pretty bad smell to me. But this is just my very fist feeling, let me read the actual code before to give a real score. -- To view, visit https://gerrit.ovirt.org/64186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
