Petr Horáček has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 202: 
Line 203: def _add_networks(nets2add, ovs_info, config, acq):
Line 204:     net_add_setup = ovs_switch.create_network_addition_setup(ovs_info)
Line 205:     net_add_setup.add(nets2add)
Line 206:     acq.acquire(net_add_setup.acquired_ifaces)
> net_add_setup.add(nets2add) is done in a transaction, so we save it was suc
before we gathered ifaces to be acquired, acquired them and then transaction 
was commited. thanks to that, we marked ifaces as ours before system changes 
(no time for NM to break it)
Line 207:     for net, attrs in six.iteritems(nets2add):
Line 208:         config.setNetwork(net, attrs)
Line 209: 
Line 210: 


-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to