Jenny Tokar has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 7626: object
> This is too generic. We need to specify type we return.
working on that :-)


https://gerrit.ovirt.org/#/c/63748/2/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 355:     'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 356:     'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
Line 357:     'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 
'vmList'},
Line 358:     'Host_getAllVmStats': {'ret': 'statsList'},
Line 359:     'Host_getAllVmIoTunePolicies': {'ret': 
Host_getAllVmIoTunePolicies_Ret},
> Same here.
If I'm removing this the only response I'm getting is: {'status': {'message': 
'Done', 'code': 0}} without the 'io_tune_policies_dict'.
And if I'm using 'Host_getAllVmIoTunePolicies': {'ret': 
'io_tune_policies_dict'} I'm getting the status and the dictionary but without 
the dictionary name and I have no way of accessing it later on.
Line 360:     'Host_setupNetworks': {'ret': 'status'},
Line 361:     'Host_setKsmTune': {'ret': 'status'},
Line 362:     'Image_cloneStructure': {'ret': 'uuid'},
Line 363:     'Image_delete': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jto...@redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Roman Mohr <rm...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to