Nir Soffer has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 9915:         type: *UUID
Line 9916: 
Line 9917:     -   description: The base volume
Line 9918:         name: base
Line 9919:         type: *CopyDataDivEndpoint
> Great for code reuse but this means we're supplying the sd and image twice 
I don't care about engine sending same value twice.

The fact that I can take the same object using the same locks and prepare 
infrastructure is so much more important.

I think we need the same locks here:

- the top volumes are read only. We must use -d so qemu does not touch the top 
volumes, since we may want to wipe them, and we need the data to get the size 
of the wipe.
- the base volume is writable

This is exactly the same as copy data.

If we find later that we want different locks, we will subclass this to 
override the locks.

We will verify that both endpoints belong to the same chain (same domain and 
image).
Line 9920: 
Line 9921:     -   description: The top volume
Line 9922:         name: top


-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to