Nir Soffer has posted comments on this change.

Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64228/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 64: 
Line 65:     def setUp(self):
Line 66:         self.scheduler = schedule.Scheduler()
Line 67:         self.scheduler.start()
Line 68:         jobs.start(self.scheduler)
Why do we need a real scheduler? a fake scheduler should be good enough, we 
already clear all jobs during teardown.
Line 69: 
Line 70:     def tearDown(self):
Line 71:         jobs._clear()
Line 72: 


-- 
To view, visit https://gerrit.ovirt.org/64228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44a7e15f2eeee8aefa9a2470f940237dc5b4469d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to