Liron Aravot has posted comments on this change.

Change subject: implementing StorageDomain.reduce
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 567:         self._validateNotMetadataPV(guid)
Line 568:         with self._extendlock:
Line 569:             lvm.reduceVG(self.sdUUID, guid)
Line 570:             self.updateMapping()
Line 571:             lvm.removePV(guid)
> Why separate patch to remove the pv?
Right, fixed.
Line 572: 
Line 573:     def _validateNotMetadataPV(self, guid):
Line 574:         lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA)
Line 575:         if lvm.isSamePV(lvm_metadata_pv, guid):


https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 754:         :type sdUUID: UUID
Line 755:         :param guid: A block device GUID
Line 756:         :type guid: str
Line 757:         """
Line 758:         job = sdm.api.reduce_sd_device.Job(jobUUID, 1, sdUUID, guid)
> Document why host_id=1 is correct, see also comment in movePV patch.
Done
Line 759:         self.sdm_schedule(job)
Line 760: 
Line 761:     @public
Line 762:     def resizePV(self, sdUUID, spUUID, guid, options=None):


-- 
To view, visit https://gerrit.ovirt.org/63269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c68f64b6c90f0af4d3fa4da94d5747b4ad9cfd6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to