Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 308:     if rc != 0:
Line 309:         raise QImgError(rc, out, err)
Line 310: 
Line 311: 
Line 312: def _qcow2_def_compat():
@Nir, Eventually we will probably pass the qcow2_compat at every call for the 
create and convert calls.
So what will be the use of this method? can we just remove it eventually?
Line 313:     value = config.get('irs', 'qcow2_compat')
Line 314:     if value not in _QCOW2_COMPAT_SUPPORTED:
Line 315:         raise exception.InvalidConfiguration(
Line 316:             "Unsupported value for irs:qcow2_compat: %r" % value)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to