Nir Soffer has submitted this change and it was merged.

Change subject: lib: response: helper to detect valid responses
......................................................................


lib: response: helper to detect valid responses

We should build responses in the API layer, and the responses
should be built from what the application layer gives back,
be that return values, or exceptions

We need a gradual upgrade path due to huge amount of legacy code,
so we need to handle the response objects built in the
application layer. For the short/mid-term, the API layer
needs to cope with both flows, modern and old.

So we need an utility to detect which kind the response
the application layer returns to the API layer.

This patch adds this utility, which will be erased once
the transition is complete, with the other scaffolding.

Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Signed-off-by: Francesco Romani <from...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/63760
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M lib/vdsm/common/response.py
M tests/responseTests.py
2 files changed, 46 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to