Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 108: 
Line 109:     if format:
Line 110:         cmd.extend(("-f", format))
Line 111:         if format == FORMAT.QCOW2:
Line 112:             cmd.extend(('-o', 'compat=' + qcow2_compat))
> I'll add this check although I think that making this check will reduce the
I meant the test for the unsupported version with raise ValueError.
Regarding the other issue of not passing the qcow2_compat at all, I agree with 
the solution of setting a default value
Line 113: 
Line 114:     if backing:
Line 115:         if not os.path.isabs(backing):
Line 116:             cwdPath = os.path.dirname(image)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to