Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 84:         self.addCopySpec("/etc/vdsm-reg/*")
Line 85:         logsize = self.getOption('logsize')
Line 86:         self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize)
Line 87:         self.__addCopySpecLogLimit("/var/log/vdsm-reg/*", logsize)
Line 88:         self._addVdsmRunDir()
> I share Nir's worry - I think we should keep collecting the key directory.
Will check
Line 89:         self.addCopySpec("@HOOKSDIR@")
Line 90:         self.addCopySpec("@VDSMLIBDIR@")
Line 91:         self.addCopySpec("/var/log/ovirt.log")
Line 92:         self.addCopySpec("/var/log/sanlock.log")


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to