Dan Kenigsberg has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64313/1/tests/testlib.py
File tests/testlib.py:

Line 45:     import mock
Line 46: mock
Line 47: 
Line 48: try:
Line 49:     from inspect import getfullargspec as getargspec
gasp. I see in 
https://docs.python.org/3/library/inspect.html#inspect.getfullargspec that this 
itself is deprecated in Python 3.5 in favor of 
https://docs.python.org/3/library/inspect.html#inspect.signature

Since Fedora already has 3.5, can we jump ahead?
Line 50: except ImportError:  # py2
Line 51:     from inspect import getargspec as getargspec
Line 52: getargspec
Line 53: 


-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to