Nir Soffer has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/64231/3/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 218:                             img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID)
Line 219:                 job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)
Line 220:                 job.run()
Line 221:                 wait_for_job(job)
Line 222:                 self.assertEqual(jobs.STATUS.DONE, job.status)
After all this setup, we did not verify the copy, jus that it did not raise.

I think we should write some data to the source image and read it from the 
target.

Can we use the helpers in this class - creating two cow volumes, and then 
corrupt the image by writing data into it - just like virt guys used to do?
This will cut the amount of code here to half.
Line 223: 
Line 224:     # TODO: Missing tests:
Line 225:     # Copy between 2 different domains
Line 226:     # Abort before copy


https://gerrit.ovirt.org/#/c/64231/3/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 66:                     return
Line 67: 
Line 68:                 # Workaround for volumes containing VM configuration 
info that
Line 69:                 # were created with invalid vdsm metadata.
Line 70:                 if self._source.is_invalid_vm_conf_disk:
is_xxx is typically a method, not property.
Line 71:                     src_format = dst_format = qemuimg.FORMAT.RAW
Line 72:                 else:
Line 73:                     src_format = self._source.qemu_format
Line 74:                     dst_format = self._dest.qemu_format


-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a333379ab21e01c9b12def78c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to