Petr Horáček has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 236:         DynamicSourceRoute.addInterfaceTracking(netEnt)
Line 237: 
Line 238:     def removeBond(self, bonding):
Line 239:         if not self.owned_device(bonding.name):
Line 240:             self.normalize_device_filename(bonding.name)
do we need to handle removals and editations? if we acquired iface in 
configure*, it must be already renamed.
Line 241:         to_be_removed = self._ifaceDownAndCleanup(bonding)
Line 242:         if to_be_removed:
Line 243:             self.configApplier.removeBonding(bonding.name)
Line 244:             if bonding.on_removal_just_detach_from_network:


https://gerrit.ovirt.org/#/c/63990/4/tests/network/func_net_basic_test.py
File tests/network/func_net_basic_test.py:

Line 71: class NetworkBasicLegacyTest(NetworkBasicTemplate):
Line 72:     __test__ = True
Line 73:     switch = 'legacy'
Line 74: 
Line 75:     def 
test_add_net_based_on_device_with_non_standard_ifcfg_file(self):
please add a TODO, we need this also for ifacquire (OVS)
Line 76:         with dummy_device() as nic:
Line 77:             NETCREATE = {NETWORK_NAME: {'nic': nic, 'switch': 
self.switch}}
Line 78:             NETREMOVE = {NETWORK_NAME: {'remove': True}}
Line 79:             with self.setupNetworks(NETCREATE, {}, NOCHK):


-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mbur...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to