Nir Soffer has posted comments on this change.

Change subject: Live Merge: teardown volume on HSM after live merge
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4771
Line 4772
Line 4773
Line 4774
Line 4775
This can be good place for tearing down the volume.


Line 4782:             self.vm.enableDriveMonitor()
Line 4783:         self.success = True
Line 4784:         self.vm.log.info("Synchronization completed (job %s)",
Line 4785:                          self.job['jobID'])
Line 4786:         self.teardown_top_volume()
This must be done *before* we set self.success to True, so it this fails, we 
will try again.
Line 4787: 
Line 4788:     def isSuccessful(self):
Line 4789:         """
Line 4790:         Returns True if this phase completed successfully.


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to