Nir Soffer has submitted this change and it was merged.

Change subject: storage: Move detect_format to new workarounds module
......................................................................


storage: Move detect_format to new workarounds module

The function Image._detect_format is a workaround for a bug where the
vdsm metadata disagrees with qemuimg about the format of a volume.
While the underlying bug has been fixed, we still need to maintain this
code in order to prevent problems with preexisting affected volumes.

For reusability and maintainability, move this function to a new module
called workarounds.py and add some basic unit tests.  This code will be
reused by sdm.copy_data in a followup patch.

Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12
Signed-off-by: Adam Litke <ali...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/64229
Reviewed-by: Nir Soffer <nsof...@redhat.com>
Continuous-Integration: Jenkins CI
Tested-by: Nir Soffer <nsof...@redhat.com>
---
M lib/vdsm/storage/Makefile.am
A lib/vdsm/storage/workarounds.py
M tests/Makefile.am
A tests/storage_workarounds_test.py
M vdsm.spec.in
M vdsm/storage/image.py
6 files changed, 151 insertions(+), 26 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64229
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to