Ala Hino has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/64301/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-09-22 15:47:20 +0300
Line 4: Commit:     Ala Hino <ah...@redhat.com>
Line 5: CommitDate: 2016-09-23 00:01:49 +0300
Line 6: 
Line 7: Live Merge: teardown volume on HSM after live merge
> Teardown
Done
Line 8: 
Line 9: If a VM is running on HSM and live merge is performed, the LV isn't
Line 10: deactivated because, the deactivation is done when deleting the volume.
Line 11: However, deleting the volume is done on SPM and this means that the LV


PS3, Line 10: ,
> This comma is redundant.
Done


PS3, Line 13:  
> missing "is"
Done


https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4782:             self.vm.enableDriveMonitor()
Line 4783:         self.success = True
Line 4784:         self.vm.log.info("Synchronization completed (job %s)",
Line 4785:                          self.job['jobID'])
Line 4786:         self.teardown_top_volume()
> This must be done *before* we set self.success to True, so it this fails, w
After another thought, I think it is better not to fail merge in this case, as 
the chances to fail here are really low and if failed, probably the env is 
severely damaged
Line 4787: 
Line 4788:     def isSuccessful(self):
Line 4789:         """
Line 4790:         Returns True if this phase completed successfully.


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to