Ala Hino has posted comments on this change.

Change subject: Live Merge: Remove volume run link after live merge
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

PS9, Line 829: self.log.error("Failed to unlink volume run link: %r",
             :                                volRunlink)
> I'd just raise without logging
Done


Line 826:             os.unlink(volRunLink)
Line 827:         except OSError as e:
Line 828:             if e.error != errno.ENOENT:
Line 829:                 self.log.error("Failed to unlink volume run link: %r",
Line 830:                                volRunlink)
> I commented about this in
Done
Line 831:                 raise
Line 832:             self.log.debug("Volume run link %r does not exist", 
volRunlink)
Line 833: 
Line 834: 


-- 
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to