Nir Soffer has posted comments on this change. Change subject: logging: More standard logging format ......................................................................
Patch Set 4: Thanks Peter, I think this is an interesting idea. For the common use case textual logs work fine. For some cases, like consuming the logs by a program, the current log is pretty bad. For example, the repoplot tool: - https://github.com/oVirt/vdsm/blob/master/contrib/repoplot - https://bugzilla.redhat.com/1081962 (look for repoplot) Having structured logs can help, but is not enough, the logs must be designed to support such usage and treated like an api, and we can do this using textual logs. To make it easier to follow operations, we added logs when operation starts and finish, for example (look for START and FINISH): - https://github.com/oVirt/vdsm/blob/master/lib/vdsm/common/api.py - https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/check.py I think we should discuss this later in the context of the entire ovirt project. -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Peter Portante <peter.porta...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
