Nir Soffer has submitted this change and it was merged. Change subject: storage: Refactor workarounds.detect_format ......................................................................
storage: Refactor workarounds.detect_format The function workarounds.detect_format accepts two volumes, checks for a special case, then returns the qemuimg formats that should be used for each volume. To make this logic more sharable, change detect_format to just detect if the problem exists and let the calling code decide which format to use. This will allow the sdm.copy_data code to use this function cleanly. Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/64230 Reviewed-by: Nir Soffer <nsof...@redhat.com> Continuous-Integration: Nir Soffer <nsof...@redhat.com> --- M lib/vdsm/storage/workarounds.py M tests/storage_workarounds_test.py M vdsm/storage/image.py 3 files changed, 18 insertions(+), 23 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
