Hello Petr Horáček, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64415
to review the following change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
......................................................................
net: Log a setup networks transaction failure when using ovs switch
When a failure occurs during the ovs setup process, an exception is
raised.
Log this failure in order to ease debugging.
Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Bug-Url: https://bugzilla.redhat.com/1379115
Signed-off-by: Edward Haas <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/64242
Reviewed-by: Petr Horáček <[email protected]>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/64415/1
diff --git a/lib/vdsm/network/netconfpersistence.py
b/lib/vdsm/network/netconfpersistence.py
index fbf7676..d0093d2 100644
--- a/lib/vdsm/network/netconfpersistence.py
+++ b/lib/vdsm/network/netconfpersistence.py
@@ -240,6 +240,10 @@
else:
config_diff = self.base_config.diffFrom(self.config)
if config_diff:
+ logging.warning(
+ 'Failed setup transaction,'
+ 'reverting to last known good network.',
+ exc_info=(ex_type, ex_value, ex_traceback))
raise ne.RollbackIncomplete(config_diff, ex_type, ex_value)
--
To view, visit https://gerrit.ovirt.org/64415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]
