Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
......................................................................


Patch Set 16:

I already fixed the trailing whitespaces issue in patchset 17.
The make check for this patch ends with success.

but the CI fails on something unexplained:
At the el7 it fails for the following reason:
Exception AttributeError: "'NoneType' object has no attribute 'udev_unref'" in 
<bound method Context.__del__ of <pyudev.core.Context object at 0x6283150>> 
ignored

And the fedora CI fails on the following:
/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/vdsm/virt/vmtune.py
                                  97      7    93%
14:18:43 
/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/vdsm/virt/vmxml.py
                                  244     17    93%
14:18:43 
--------------------------------------------------------------------------------------------------------------------------------------
14:18:43 TOTAL                                                                  
                                            42807  20436    52%
14:18:43 ----------------------------------------------------------------------
14:18:43 Ran 2686 tests in 203.690s
14:18:43 
14:18:43 FAILED (SKIP=141, errors=6, failures=8)
14:18:43 Makefile:1291: recipe for target 'check' failed
14:18:43 make[1]: *** [check] Error 1
14:18:43 make[1]: Leaving directory 
'/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests'
14:18:43 Makefile:1011: recipe for target 'tests' failed
14:18:43 make: *** [tests] Error 2
14:18:43 Took 678 seconds
14:18:43 ===================================
14:18:43 ##!
14:18:43 ##! ERROR ^^^^^^^


None of them seem related to this change...

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to