Nir Soffer has posted comments on this change. Change subject: sd: Select qcow2_compat by storage domain version ......................................................................
Patch Set 11: (1 comment) Code is fine, but a test is missing. https://gerrit.ovirt.org/#/c/64244/11/tests/sdm_indirection_tests.py File tests/sdm_indirection_tests.py: Line 51: pass Line 52: Line 53: @recorded Line 54: def qcow2_compat(self, key): Line 55: pass This adds only the "fake" implementation, we need to add a test that will fail without this implementation, and without the code in StorageDomain calling manifest's qcow2_compat. Line 56: Line 57: @recorded Line 58: def getVersion(self): Line 59: pass -- To view, visit https://gerrit.ovirt.org/64244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
