Nir Soffer has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt' Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@' Line 156: Line 157: # location of the certificates Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm') > I'm sorry to tell you guys that this is not possible, it's causing circular Puting all constants in single module is not junkyard, this is a good way to share constants in multiple modules without creating circular dependencies. If you want to limit the junk, create constants module for each package (common, network, virt, storage). Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem') Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem') -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
