Nir Soffer has posted comments on this change. Change subject: storage: Introduce VolumeManifest.operation context ......................................................................
Patch Set 2: (1 comment) Nice, needs more time to review the tests. https://gerrit.ovirt.org/#/c/64362/2/tests/storage_volume_test.py File tests/storage_volume_test.py: Line 116: self.assertEqual(2, vol.setMetadata.nr_calls) Line 117: Line 118: def test_operation_fail_inside_context(self): Line 119: img_id = str(uuid.uuid4()) Line 120: vol_id = str(uuid.uuid4()) I think its time to introduce a helper to create uuid string without repeating this boilerplate everywhere. Line 121: Line 122: with fake_env('file') as env: Line 123: env.make_volume(MB, img_id, vol_id) Line 124: vol = env.sd_manifest.produceVolume(img_id, vol_id) -- To view, visit https://gerrit.ovirt.org/64362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
