Francesco Romani has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64468/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 789: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED], Line 790: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING], Line 791: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS], Line 792: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT], Line 793: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0), > I this our standard, adding default values for missing keys, or we omit mis The standard is to add default values. So far that made Engine's life a bit easier. Since we are adding a large patchset, we will review this approach with Engine devs. Line 794: # available since libvirt 1.3 Line 795: stats.get('memory_dirty_rate', -1), Line 796: # available since libvirt 1.3 Line 797: stats.get('memory_iteration', -1), -- To view, visit https://gerrit.ovirt.org/64468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
