Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64514
to review the following change.
Change subject: storage: fileUtils: drop redundant warning
......................................................................
storage: fileUtils: drop redundant warning
The usage of warnings.warn in the fileUtils
looks redundant, since we log the same information
in the line before.
So this patch just drops it.
Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Related-To: https://bugzilla.redhat.com/1364149
Bug-Url: https://bugzilla.redhat.com/1369822
Backport-To: 4.0
Signed-off-by: Francesco Romani <from...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/62208
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsof...@redhat.com>
---
M lib/vdsm/storage/fileUtils.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/64514/1
diff --git a/lib/vdsm/storage/fileUtils.py b/lib/vdsm/storage/fileUtils.py
index 0fa4901..00c64fa 100644
--- a/lib/vdsm/storage/fileUtils.py
+++ b/lib/vdsm/storage/fileUtils.py
@@ -35,7 +35,6 @@
import subprocess
import sys
import types
-import warnings
from contextlib import closing
from contextlib import contextmanager
@@ -217,7 +216,6 @@
if not stat.S_ISDIR(statinfo.st_mode):
raise OSError(errno.ENOTDIR, "Not a directory %s" % dirPath)
log.debug("Using existing directory: %s", dirPath)
- warnings.warn("Using existing direcotory: %s" % dirPath, stacklevel=2)
if mode is not None:
curMode = stat.S_IMODE(statinfo.st_mode)
if curMode != mode:
--
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
