Nir Soffer has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 96: class CopyDataDivEndpoint(properties.Owner):
Line 97:     sd_id = properties.UUID(required=True)
Line 98:     img_id = properties.UUID(required=True)
Line 99:     vol_id = properties.UUID(required=True)
Line 100:     generation_id = properties.Integer(required=False, minval=0)
> Done
maxval=sc.MAX_GENERATION even better :-)
Line 101: 
Line 102:     def __init__(self, params, host_id, writable):
Line 103:         self.sd_id = params.get('sd_id')
Line 104:         self.img_id = params.get('img_id')


-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to