Nir Soffer has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge ......................................................................
Patch Set 6: (2 comments) Did you verify the current code with both top layer merge and internal layer merge, or you just copied the verified flag from a previous version? https://gerrit.ovirt.org/#/c/64301/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4779: "(job %s)", self.job['jobID']) Line 4780: self.vm._syncVolumeChain(self.drive) Line 4781: if self.doPivot: Line 4782: self.vm.enableDriveMonitor() Line 4783: self.teardown_top_volume() How is this needed only after pivot? We need to teardown the volume after any merge, not only top layer merge. I think I suggested to add teardown in this line, but not inside the if block. Line 4784: self.success = True Line 4785: self.vm.log.info("Synchronization completed (job %s)", Line 4786: self.job['jobID']) Line 4787: # At this point, merge has succesfully completed and the top volume is Line 4788: # not part of the chain. Now, we want to teardown the top volume. Note Line 4789: # that if volume deactivation fails, we don't want to fail the merge Line 4790: # whole operation as the VM is running without issues. It is worth to Line 4791: # note that if volume deactivation fails, chances are high that the Line 4792: # environment is severely damaged. This comment conflict with the code now. Line 4793: Line 4794: def isSuccessful(self): Line 4795: """ Line 4796: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
