Nir Soffer has posted comments on this change. Change subject: storage: GenerationMismatch exception ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py File lib/vdsm/storage/exception.py: Line 1789: Line 1790: Line 1791: class GenerationMismatch(StorageException): Line 1792: code = 911 Line 1793: message = "The provided generation does not match the actual generation." Most error messages do not end with period, I think this is good. The message from vdsm is not the error message show to a user, is is text engine may show as part of an error, maybe with additional info, so this is not the place to format a sentence. $ grep 'message =' lib/vdsm/storage/exception.py | egrep '\."$' | wc -l 2 $ grep 'message =' lib/vdsm/storage/exception.py | egrep -v '\."$' | wc -l 290 This search is missing some long lines wrapped to two lines, but the trend is clear. Line 1794: Line 1795: def __init__(self, requested, actual): -- To view, visit https://gerrit.ovirt.org/64543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
