Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py File lib/vdsm/storage/constants.py: Line 165: # ascii values, but limit non-ascii values, which are encoded by engine Line 166: # using 4 bytes per character. Line 167: DESCRIPTION_SIZE = 210 Line 168: DEFAULT_GENERATION = 0 Line 169: MAX_GENERATION = 2 ** 63 - 1 Let's reduce this to 999 Line 170: Line 171: # Block volume metadata tags Line 172: TAG_PREFIX_MD = "MD_" Line 173: TAG_PREFIX_MDNUMBLKS = "MS_" -- To view, visit https://gerrit.ovirt.org/64484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
