Nir Soffer has posted comments on this change.

Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/63027/12/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 5654: 
Line 5655:         -   defaultvalue: null
Line 5656:             description: The GUID of the first device containing the 
domain
Line 5657:                 metadata lv for block storage domains (optional)
Line 5658:             name: metadataDevice
> I am wondering if this is too much detail for this API.  What engine really
+1
Line 5659:             type: string
Line 5660:         type: object
Line 5661: 
Line 5662:     StorageDomainStatus: &StorageDomainStatus


-- 
To view, visit https://gerrit.ovirt.org/63027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to