Nir Soffer has posted comments on this change. Change subject: vm: Add qcow2_compat on create ......................................................................
Patch Set 15: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/64377/15/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2701: try: Line 2702: qemuimg.create(transientPath, format=qemuimg.FORMAT.QCOW2, Line 2703: backing=diskParams['path'], Line 2704: backingFormat=driveFormat, Line 2705: qcow2Compat=self._dom.qcow2_compat()) I commented before - you need a storage domain manifest object, vm._dom is a libvirt.virDomain object. Line 2706: os.fchmod(transientHandle, 0o660) Line 2707: except Exception: Line 2708: os.unlink(transientPath) # Closing after deletion is correct Line 2709: self.log.exception("Failed to create the transient disk for " -- To view, visit https://gerrit.ovirt.org/64377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
