Adam Litke has posted comments on this change. Change subject: storage: Increment generation when completing operation ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64487/4/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 512 Line 513 Line 514 Line 515 Line 516 > It would be helpful to comment here that we intentionally do not use try-fi Good point. I'll add this comment in the patch where this code is created. -- To view, visit https://gerrit.ovirt.org/64487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
