Nir Soffer has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/64479/7/tests/storage_sdm_copy_data_test.py File tests/storage_sdm_copy_data_test.py: Line 275 Line 276 Line 277 Line 278 Line 279 setting the ready event here will avoid a small race. Line 267: job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest) Line 268: start_thread(job.run) Line 269: fake_convert.ready_event.wait() Line 270: job.abort() Line 271: wait_for_job(job) Lets replace this with joining the thread. Line 272: self.assertEqual(jobs.STATUS.ABORTED, job.status) Line 273: self.assertEqual(sc.ILLEGAL_VOL, dst_vol.getLegality()) Line 274: Line 275: # TODO: Missing tests: Line 277: # Abort before copy Line 278: Line 279: Line 280: class FakeQemuConvertChecker(object): Line 281: def __init__(self, src_vol, dst_vol, error=None, abort_wait=False): abort_wait -> wait_for_abort Line 282: self.src_vol = src_vol Line 283: self.dst_vol = dst_vol Line 284: self.error = error Line 285: self.ready_event = threading.Event() -- To view, visit https://gerrit.ovirt.org/64479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
