Fabian Deutsch has posted comments on this change. Change subject: service: Add vdsm-tool-configure service ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64904/3/static/usr/lib/systemd/system/vdsm-tool-configure.service File static/usr/lib/systemd/system/vdsm-tool-configure.service: Line 1: [Unit] Line 2: Description=configure vdsm > again, it's more of a configuration of the system FOR vdsm. The only case when this condition will kick in, is when the timestamp of /usr changes. And this is only the case on major updates - or on image based systems like Node and Atomic. Bottom line: No, with this condition, the service will usually not be triggered on regular hosts - because the timestamp of /usr does not change (AFAIU) Line 3: Conflicts=shutdown.target Line 4: Before=supervdsmd.service vdsmd.service shutdown.target systemd-update-done.service Line 5: ConditionNeedsUpdate=/usr Line 6: -- To view, visit https://gerrit.ovirt.org/64904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c4fffb09d2a5c49b0462693fb2beca47fb58ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
