Dan Kenigsberg has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/65007/1/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 111: kwargs.get('maxBandwidth') or Line 112: config.getint('vars', 'migration_max_bandwidth') Line 113: ) Line 114: self._autoConverge = utils.tobool(autoConverge) Line 115: self._compressed = utils.tobool(compressed) > When does this value come from? Nir, you are right; and there has been a long-standing effort to normalize Vdsm API (https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:storgare_schema_fixes hint hint) However, we are not there (yet). There are dozens of calls to tobool in the code, most of them outside of a canonicalization layer. This place is no different, and it is urgently required to solve a 4.0 bug. Let us take it in, with an apologetic TODO, promising to fix it in the API layer. Line 116: self._incomingLimit = kwargs.get('incomingLimit') Line 117: self._outgoingLimit = kwargs.get('outgoingLimit') Line 118: self.status = { Line 119: 'status': { -- To view, visit https://gerrit.ovirt.org/65007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
