Michal Skrivanek has posted comments on this change. Change subject: osinfo: properly parse kernel compile time ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 178: return selinux Line 179: Line 180: Line 181: def package_versions(): Line 182: def kernelDict(): > Dan, the patch literally changes 2 characters if you ignore the comment - I yes, but engineis the only consumer of this API and none of the supported engines are even looking at that field. So should be dropped from all other places in vdsm. In a separate patch if you prefer Line 183: ret = os.uname() Line 184: try: Line 185: ver, rel = ret[2].split('-', 1) Line 186: except ValueError: -- To view, visit https://gerrit.ovirt.org/65059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc9b0fe5446abd5405db6efff6b7f9f16468bc9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org