Piotr Kliczewski has posted comments on this change.

Change subject: clientIF: Fix reactor life cycle
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File tests/protocoldetectorTests.py:

Line 110:         self.acceptor_address = None
Line 111: 
Line 112:     def tearDown(self):
Line 113:         if self.acceptor:
Line 114:             self.acceptor.stop()
> If we don't call acceptor close, and later we change the test so we don't c
What hidden dependencies? Is it possible to use acceptor without reactor?
Line 115:         if self.reactor:
Line 116:             self.reactor.stop()
Line 117: 
Line 118:     # Testing


-- 
To view, visit https://gerrit.ovirt.org/65188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to