Piotr Kliczewski has posted comments on this change.

Change subject: protocoldetector: Fix random double close
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206:         self._handlers.append(detector)
Line 207: 
Line 208:     def stop(self):
Line 209:         self.log.debug("Stopping Acceptor")
Line 210:         self._acceptor.close()
> No, this creates broken stop method that stop the reactor instead of the ac
what is your definition of broken because it seems I have a different one.
Line 211:         self._reactor.stop()
Line 212: 
Line 213: 
Line 214: class _CannotDetectProtocol(Exception):


-- 
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to