Milan Zamazal has posted comments on this change.

Change subject: [WIP] use libvirt domain xml prepared in advance
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 21: from operator import itemgetter
Line 22: import xml.dom
Line 23: import xml.dom.minidom
Line 24: import xml.etree.ElementTree as etree
Line 25: from xml.dom.minidom import parseString as _domParseStr
> code is migrated to etree, Milan, how far are we for this module?
I tried to address suggestions from the reviewers on 
https://gerrit.ovirt.org/55769, so I'm going to push that patch for merge now. 
If it succeeds then all new code should use the XML helpers from the patch or 
etree directly. If it doesn't succeed before this (Arik's) patch will be merged 
then there is no big problem with it as we need to check for minidom remnants 
anyway.
Line 26: 
Line 27: from vdsm import constants
Line 28: from vdsm import cpuarch
Line 29: from vdsm import utils


-- 
To view, visit https://gerrit.ovirt.org/65182
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to