Martin Polednik has posted comments on this change.

Change subject: static: move man under static
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am
File static/Makefile.am:

PS5, Line 24: usr
> same comment as parent patch about hardcoded paths.
Same as parent patch, this is path within source tree, not the distribution 
target.


PS5, Line 33: etc
> hardcoding /etc is kinda fine, a lot of thing can broke otherwise, but stuf
Ditto.


PS5, Line 93: ./usr/lib/systemd
> (yes, I noticed too late)
Ditto.


-- 
To view, visit https://gerrit.ovirt.org/62549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to