Nir Soffer has posted comments on this change.

Change subject: tests: Add test for terminating a terminated process
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py
File tests/utilsTests.py:

Line 114:         self.proc.terminate()
Line 115:         self.proc.wait()
Line 116: 
Line 117:         def fail():
Line 118:             raise RuntimeError("Attempt to kill a terminated process")
> I see that copy and paste are our friends :)
Did you notice that each exception has different text?

Please suggest how to improve this while keeping the code clear.
Line 119: 
Line 120:         self.proc.kill = fail
Line 121:         with utils.terminating(self.proc):
Line 122:             pass


-- 
To view, visit https://gerrit.ovirt.org/65328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0f06c28857664cc49beb938f33ac3c9d07ca3b6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to